Skip to content

Conversation

@bruAristimunha
Copy link
Contributor

@bruAristimunha bruAristimunha commented Nov 3, 2025

PR Description

fixes Failing to load clinical Brainvision formatted ECoG data in MNE tutorial due to timezones #1398

Address a bug that caused issues when reading BIDS datasets with local acquisition times on Windows. Update documentation and include tests to ensure proper functionality.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@bruAristimunha
Copy link
Contributor Author

@sappelhoff

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (b999865) to head (2b762ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1465   +/-   ##
=======================================
  Coverage   96.91%   96.92%           
=======================================
  Files          43       43           
  Lines        9990    10003   +13     
=======================================
+ Hits         9682     9695   +13     
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff sappelhoff merged commit 9c550e1 into mne-tools:main Nov 3, 2025
24 checks passed
@bruAristimunha bruAristimunha deleted the timezone-issue branch November 3, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing to load clinical Brainvision formatted ECoG data in MNE tutorial due to timezones

2 participants